Skip to content

Adjust existing e2e tests to provide custom Pypi index URL #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2024
Merged

Adjust existing e2e tests to provide custom Pypi index URL #459

merged 1 commit into from
Feb 7, 2024

Conversation

sutaakar
Copy link
Contributor

@sutaakar sutaakar commented Feb 1, 2024 •
edited
Loading

Issue link

RHOAIENG-310
Depends on project-codeflare/codeflare-common#32

What changes have been made

Added support for defining PyPI connection properties, minor fixes for ODH tests.

Verification steps

Run e2e tests in disconnected environment with provided env variables.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-ci openshift-ci bot added the lgtm label Feb 1, 2024
@openshift-ci openshift-ci bot removed the lgtm label Feb 2, 2024
@sutaakar sutaakar marked this pull request as ready for review February 2, 2024 14:53
@sutaakar
Copy link
Contributor Author

sutaakar commented Feb 2, 2024

@jiripetrlik @abhijeet-dhumal Please take a look. e2e tests should work well now in disconnected environment, pip address is passed using env variable. For ODH TestMCADRay I had to pass values using requirements.txt due to https://issues.redhat.com/browse/RHOAIENG-65.

ODH TestMnistPyTorchMCAD is not fixed for disconnected cluster yet, need to find and adjust proper image for training execution. I didn't want to block the PR because of that.

@openshift-ci openshift-ci bot added the lgtm label Feb 3, 2024
@sutaakar
Copy link
Contributor Author

sutaakar commented Feb 7, 2024

/approve

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhijeet-dhumal, jiripetrlik, sutaakar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Feb 7, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 1264faa into project-codeflare:main Feb 7, 2024
@sutaakar sutaakar deleted the pypi branch February 7, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiripetrlik jiripetrlik jiripetrlik approved these changes

@abhijeet-dhumal abhijeet-dhumal abhijeet-dhumal approved these changes

@Fiona-Waters Fiona-Waters Awaiting requested review from Fiona-Waters

@tedhtchang tedhtchang Awaiting requested review from tedhtchang

Assignees

@jiripetrlik jiripetrlik

@abhijeet-dhumal abhijeet-dhumal

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sutaakar @jiripetrlik @abhijeet-dhumal